fix: Add division by temperature in training model#316
Merged
parthchadha merged 6 commits intomainfrom May 6, 2025
Merged
Conversation
SahilJain314
reviewed
May 5, 2025
…aining and generation are computing the same thing Signed-off-by: Parth Chadha <pchadha@nvidia.com>
parthchadha
force-pushed
the
pchadha/training-temp-fix
branch
from
c0ed20d to
34c97e5
Compare
parthchadha
added
CI:L0
SahilJain314
previously approved these changes
May 5, 2025
Contributor
SahilJain314
left a comment
SahilJain314
left a comment
There was a problem hiding this comment.
doubled checked that tests use the temperature parameter. LGTM
Signed-off-by: Parth Chadha <pchadha@nvidia.com>
parthchadha
added
CI:L0
terrykong
previously approved these changes
May 5, 2025
SahilJain314
previously approved these changes
May 5, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…ot need generation Signed-off-by: Parth Chadha <pchadha@nvidia.com>
…pchadha/training-temp-fix
parthchadha
added
CI:L0
terrykong
approved these changes
May 6, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
YzjiaoNvd
pushed a commit
to YzjiaoNvd/NeMo-RL
that referenced
this pull request
Jun 10, 2025
Signed-off-by: Parth Chadha <pchadha@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add division by temperature in training model to reflect that training and generation are computing the same thing
logprob error with this change:
Without this change:
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information